Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: add Kubernetes discovery support #13262

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

adelcast
Copy link
Contributor

The K8 discovery mechanism, enabled by the druid-kubernetes-extension, relies on each pod advertising its name and namespace on the env variables POD_NAME and POD_NAMESPACE [1]. Add env variables to all deployments/statefulsets.

[1] https://druid.apache.org/docs/latest/development/extensions-core/kubernetes.html

Signed-off-by: Alejandro del Castillo alejandro.delcastillo@ni.com

Description

Helm deployment is not compatible with the druid-kubernetes-extension since the extension relies on each pod advertising its name and namespace on the env variables POD_NAME and POD_NAMESPACE

Add POD_NAME and POD_NAMESPACE env variables to all deployments/statefulsets.

Release note

  • Add K8 discovery support to helm charts.

This PR has:

  • [X ] been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • [ X] a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • [ X] been tested in a test Druid cluster.

The K8 discovery mechanism, enabled by the druid-kubernetes-extension,
relies on each pod advertising its name and namespace on the env
variables POD_NAME and POD_NAMESPACE [1]. Add env variables to all
deployments/statefulsets.

[1] https://druid.apache.org/docs/latest/development/extensions-core/kubernetes.html

Signed-off-by: Alejandro del Castillo <alejandro.delcastillo@ni.com>
@FrankChen021 FrankChen021 added the Helm Chart https://github.com/apache/druid/tree/master/helm/druid label Oct 26, 2022
@abhishekagarwal87 abhishekagarwal87 merged commit de7ef81 into apache:master Oct 28, 2022
@abhishekagarwal87
Copy link
Contributor

thank you for your contribution @adelcast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Helm Chart https://github.com/apache/druid/tree/master/helm/druid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants