Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console: expose in the UI that a query is stuck waiting for task slots #13291

Merged
merged 3 commits into from
Nov 1, 2022

Conversation

vogievetsky
Copy link
Contributor

This is a UI followup to #13263

This PR adds two things:

(1) a capacity check + notification when clicking the Run (or Preview) buttons:

image

image

(2) a textual indication about running / pending tasks when a stage is "stuck" due to not having enough task slots

image

Hopefully this will reduce confusion among users that get tripped up on this today.

Also updated the tests with newly acquired result payloads

@vogievetsky vogievetsky added Release Notes Area - Web Console Area - Query UI Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Oct 31, 2022
Copy link
Contributor

@cryptoe cryptoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@vogievetsky vogievetsky merged commit 176934e into apache:master Nov 1, 2022
@vogievetsky vogievetsky deleted the show-stuck-stages branch November 1, 2022 16:41
@vogievetsky vogievetsky mentioned this pull request Nov 16, 2022
1 task
@kfaraz kfaraz added this to the 25.0 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Query UI Area - Web Console Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants