Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested column support for ORC #13375

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

clintropolis
Copy link
Member

@clintropolis clintropolis commented Nov 16, 2022

Description

This PR adds support for Druid nested columns and JSON functions to ORC input files, fixing up the flattening conversion machinery to handle nested outputs, and fixing a few other conversion related bugs.

Release note

ORC input files are now supported by Druid nested columns and associated JSON transform functions.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

Copy link
Contributor

@paul-rogers paul-rogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code and tests look fine. Can't comment on the detailed semantics. I'm trusting that the extensive unit tests prove that the semantics are valid.

@clintropolis clintropolis merged commit 8c9ffcf into apache:master Nov 18, 2022
@clintropolis clintropolis deleted the nested-column-orc branch November 18, 2022 05:08
@kfaraz kfaraz added this to the 25.0 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants