Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quieter streaming supervisors. #13392

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Nov 21, 2022

Eliminates two common sources of noise with Kafka supervisors that have large numbers of tasks and partitions:

  1. Log the report at DEBUG rather than INFO level at each run cycle.
    It can get quite large, and can be retrieved via API when needed.

  2. Use log4j2.xml to quiet down the org.apache.kafka.clients.consumer.internals
    package. Avoids a log message per-partition per-minute as part of seeking
    to the latest offset in the reporting thread. In the tasks, where this
    sort of logging might be more useful, we have another log message with
    the same information: "Seeking partition[%s] to[%s]".

Eliminates two common sources of noise with Kafka supervisors that have
large numbers of tasks and partitions:

1) Log the report at DEBUG rather than INFO level at each run cycle.
   It can get quite large, and can be retrieved via API when needed.

2) Use log4j2.xml to quiet down the org.apache.kafka.clients.consumer.internals
   package. Avoids a log message per-partition per-minute as part of seeking
   to the latest offset in the reporting thread. In the tasks, where this
   sort of logging might be more useful, we have another log message with
   the same information: "Seeking partition[%s] to[%s]".
@kfaraz kfaraz added this to the 25.0 milestone Nov 21, 2022
@gianm
Copy link
Contributor Author

gianm commented Nov 21, 2022

Code coverage checks are failing because only one line changed, and it only gets logged at debug level. I suggest we merge the patch anyway, ignoring the coverage checks, once other tests are passing. I restarted the other failure, which I think was a flake.

@kfaraz
Copy link
Contributor

kfaraz commented Nov 21, 2022

Code coverage checks are failing because only one line changed, and it only gets logged at debug level. I suggest we merge the patch anyway, ignoring the coverage checks, once other tests are passing. I restarted the other failure, which I think was a flake.

Yeah, makes sense. I had triggered the phase 2 tests. I think some are still running. We can merge once they finish.

@gianm
Copy link
Contributor Author

gianm commented Nov 21, 2022

Yeah, makes sense. I had triggered the phase 2 tests. I think some are still running. We can merge once they finish.

Thanks. It looks like they're done now. I'll merge this.

@gianm gianm merged commit c61313f into apache:master Nov 21, 2022
@gianm gianm deleted the supervisor-quieter branch November 21, 2022 07:53
gianm added a commit to gianm/druid that referenced this pull request Jun 16, 2023
Follow-up to apache#13392, which added this to a single log4j2.xml.
abhishekagarwal87 pushed a commit that referenced this pull request Jun 19, 2023
Follow-up to #13392, which added this to a single log4j2.xml.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants