Web console: be more robust to aux queries failing and improve kill tasks #13431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vogievetsky
changed the title
gianm
approved these changes
Nov 28, 2022
vogievetsky
added a commit
to vogievetsky/druid
that referenced
this pull request
Nov 29, 2022
…asks (apache#13431) * be more robust to aux queries failing * feedback fixes * remove empty block * fix spelling * remove killAllDataSources from the console
This was referenced Nov 29, 2022
vogievetsky
added a commit
that referenced
this pull request
Dec 1, 2022
* add ability to make inputFormat part of the example datasets (#13402) * Web console: Index spec dialog (#13425) * add index spec dialog * add sanpshot * Web console: be more robust to aux queries failing and improve kill tasks (#13431) * be more robust to aux queries failing * feedback fixes * remove empty block * fix spelling * remove killAllDataSources from the console * don't render duration if aggregated (#13455)
This was referenced Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two things:
Be more robust if an auxiliary query fails. For example the services view uses the
sys.serverstable to load most of the data but it also loads the workers from the coordinator. If the coordinator is down temporarily we do not want to fail the whole query, instead do the best we can with the info we have and also pop up an error toast notification that something went wrong.Following this discussion on Slack: https://apachedruidworkspace.slack.com/archives/C030K0Z7S1Z/p1669222099825209 the kill task dialog now lets you pick and interval and sets a default that does not include the future.
This should fix #10508 and #11568