-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting on Window Functions #13458
Merged
Merged
Starting on Window Functions #13458
Changes from 30 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
a53bdb8
Processors for Window Processing
imply-cheddar 54e8c65
Wire up windowed processors with a query type that
imply-cheddar a5eead8
wip
gianm f3b61ef
Merge remote-tracking branch 'imply-cheddar/window-operations' into s…
gianm f5ccb09
WindowOperatorQuery SQL bindings
gianm 31b4005
Processors for Window Processing
imply-cheddar cbcb264
Wire up windowed processors with a query type that
imply-cheddar 32971ac
Wire up windowed processors with a query type that
imply-cheddar 76e8645
Initial SQL parsing/planning for window functions
imply-cheddar 2148a78
Some SQL tests for window functions
imply-cheddar ffde5a9
Add Javadoc to interfaces
imply-cheddar b72a1b2
Reformat Code and optimize imports
imply-cheddar b5bfad4
Add license header
imply-cheddar 5131674
2 whitespaces in the copyright clob
imply-cheddar 5f43d28
Test and style fixes
imply-cheddar a979d83
Fix dependencies
imply-cheddar d012b86
Forbidden APIs
imply-cheddar 598c373
Checkstyle
imply-cheddar f989459
Tests for coverage
imply-cheddar 1300de7
Support SQL-compatible mode in tests
imply-cheddar 2a2023f
Some initial tests for RowsAndColumns directly
imply-cheddar 70488b7
Tests and style
imply-cheddar f3d3270
Expand branch coverage for tests
imply-cheddar 851acb8
Tests and style
imply-cheddar 299d735
Make windowing off by default
imply-cheddar ea566d9
Merge remote-tracking branch 'apache/master' into windowinging
imply-cheddar 935864c
Make it compile after merge.
imply-cheddar f38945c
Changes from code review
imply-cheddar 8cc8235
Checkstyle and tests
imply-cheddar 01cea90
Merge remote-tracking branch 'apache/master' into windowinging
imply-cheddar edb06d8
Fix comment
imply-cheddar File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get why you did it this way, but it's a bummer, since nothing really stops the inexorable Objectification of the Ts in this interface, except moving away from Jackson serde of plain
Object
andObject[]
andList<Object>
. That's the real issue. I think we'll be able to move away from that as we go to frame and frame channel RPC, so, I am okay with this for that reason.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.