Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some intellij inspections in druid-processing #13823

Merged
merged 3 commits into from Feb 21, 2023
Merged

fix some intellij inspections in druid-processing #13823

merged 3 commits into from Feb 21, 2023

Conversation

clintropolis
Copy link
Member

Description

Working through the list of inspection failures as a follow-up to #13698.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 20, 2023
View reviewed changes
...ng/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java
@@ -93,7 +93,7 @@
BinaryOperator<T> combineFn,
boolean hasTimeout,
long timeoutMillis,
int queryPriority,
@SuppressWarnings("unused") int queryPriority,

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'queryPriority' is never used.
abhishekrb19
abhishekrb19 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@abhishekrb19 abhishekrb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a quick scan this change-set looks good. The static checks are also succeeding, which is great 🎉

@abhishekagarwal87 abhishekagarwal87 merged commit 614205f into apache:master Feb 21, 2023
@clintropolis clintropolis deleted the resolve-some-inspections branch February 21, 2023 04:20
@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekagarwal87 abhishekagarwal87 abhishekagarwal87 approved these changes

@abhishekrb19 abhishekrb19 abhishekrb19 approved these changes

Assignees
No one assigned
Labels
Development Blocker
Projects
None yet
Milestone
26.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clintropolis @abhishekagarwal87 @abhishekrb19