New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing license for jakarta.activation against module druid-avro-extensions #13845
Conversation
@@ -56,7 +56,7 @@ jobs: | |||
- name: packaging check | |||
run: | | |||
./.github/scripts/setup_generate_license.sh | |||
${MVN} clean install -Prat -Pbundle-contrib-exts --fail-at-end \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure we should remove it, the packaging check was added to make sure that everything builds correctly, including contrib extensions (at least that is how i remember it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping this profile in the command leads to misleading warning messages such as this one:
https://github.com/apache/druid/actions/runs/4261844965/jobs/7416643271#step:5:22535
Warning: The requested profile "bundle-contrib-exts" could not be activated because it does not exist.
This is because the profile bundle-contrib-exts
is present only in the distribution module and that module has been excluded in the first command here.
druid/.github/workflows/static-checks.yml
Lines 56 to 62 in 6bb5eff
- name: packaging check | |
run: | | |
./.github/scripts/setup_generate_license.sh | |
${MVN} clean install -Prat -Pbundle-contrib-exts --fail-at-end \ | |
-pl '!benchmarks, !distribution' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS} -Dweb.console.skip=false -T1C | |
${MVN} install -Prat -Pdist -Pbundle-contrib-exts --fail-at-end \ | |
-pl 'distribution' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS} -Dweb.console.skip=false -T1C |
I have retained the -Pbundle-contrib-exts
for the second command, where the distribution module has been targeted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, thanks I was confused, as long as it is still building them for the distribution 👍
Forgot to ask - do you know why this check has only recently started failing? |
I think it probably only fails in java 9+, since this is the replacement for |
Yeah, not sure why this started failing recently, but it were the jdk8 static checks that were failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @kfaraz !
Thanks for the reviews, @suneet-s , @clintropolis ! |
Example failing license check:
https://github.com/apache/druid/actions/runs/4259979145/jobs/7412698385