Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow druid-kubernetes-overlord-extensions to be loaded in any druid service #13872

Merged
merged 8 commits into from Mar 3, 2023
Merged

Allow druid-kubernetes-overlord-extensions to be loaded in any druid service #13872

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
08928d9
Only setup Kubernetes task runner bindings for the overlord service
Mar 2, 2023
77b3f73
Merge branch 'apache:master' into druid-kubernetes-module-loadable-in…
nlippis Mar 2, 2023
375c101
Use LoadScope
Mar 2, 2023
c376832
Merge remote-tracking branch 'upstream/master' into druid-kubernetes-…
Mar 2, 2023
86ece9f
Merge branch 'druid-kubernetes-module-loadable-in-any-druid-service' …
Mar 2, 2023
5e12f0f
Remove whitespace change in order to get around code coverage
Mar 2, 2023
b8832c8
revert whitespace change in order to get around code coverage
Mar 2, 2023
e2ff348
Merge branch 'master' of https://github.com/apache/druid into druid-k…
Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...es-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/K8sOverlordModule.java
View file
Open in desktop
Expand Up @@ -22,11 +22,13 @@
import com.google.inject.Binder;
import com.google.inject.Key;
import com.google.inject.multibindings.MapBinder;
import org.apache.druid.discovery.NodeRole;
import org.apache.druid.guice.Binders;
import org.apache.druid.guice.IndexingServiceModuleHelper;
import org.apache.druid.guice.JsonConfigProvider;
import org.apache.druid.guice.LazySingleton;
import org.apache.druid.guice.PolyBind;
import org.apache.druid.guice.annotations.LoadScope;
import org.apache.druid.indexing.common.config.FileTaskLogsConfig;
import org.apache.druid.indexing.common.tasklogs.FileTaskLogs;
import org.apache.druid.indexing.overlord.TaskRunnerFactory;
Expand All @@ -37,9 +39,9 @@
import org.apache.druid.tasklogs.TaskLogPusher;
import org.apache.druid.tasklogs.TaskLogs;

@LoadScope(roles = NodeRole.OVERLORD_JSON_NAME)
public class K8sOverlordModule implements DruidModule
{

@Override
public void configure(Binder binder)
{
Expand Down