New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document our conventions for writing messages #13916
Conversation
1a08e40
to
011e983
Compare
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as-is. Had a couple of questions that don't block my approval. Thanks for starting this off!
@paul-rogers @gianm both of you left comments that I have addressed with updates to the text. Just pinging to give you a chance to double check the adjustments and leave more comments if you do not feel like the new explanations make sense. The thing I'm mostly wondering about is the explanation about |
65024a0
to
06b83e5
Compare
@imply-cheddar, error messages are for end users. Even when they are for sys admins or devs, they go to end users first. As an end user of many products, I find That said, the code works fine without spaces and users can get used to Druid style. So, LGTM. |
This adds some documentation for our message-writing conventions.