Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update com.github.eirslett to fix bad zip issue #15556

Merged
merged 1 commit into from Dec 14, 2023
Merged

Update com.github.eirslett to fix bad zip issue #15556

merged 1 commit into from Dec 14, 2023

Conversation

pranavbhole
Copy link
Contributor

Description

fix bad zip issue and update the eirslett
eirslett/frontend-maven-plugin#1125

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@clintropolis clintropolis merged commit 81fe855 into apache:master Dec 14, 2023
83 checks passed
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
@LakshSingla LakshSingla mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soumyava soumyava soumyava approved these changes

Assignees
No one assigned
Labels
Area - Dependencies Area - Web Console
Projects
None yet
Milestone
29.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pranavbhole @soumyava @clintropolis @LakshSingla