Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure integration tests for 'azureStorage' input type #15799

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

georgew5656
Copy link
Contributor

Adding ingest/query tests for data ingested with the azureStorage ingest spec.

Description

This is a followup to 3e51224.

Since there is a new input type i added a couple integ tests for it.

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

It might be nice to test the read from a different storage account functionality as well (these tests still read from a single storage account), but I think that should be a separate change.

I tested these cases locally and they all succeeded as expected.


Key changed/added classes in this PR
  • AbstractCloudInputSourceParallelIndexTest
  • ITAzureV2ParallelIndexTest
  • ITAzureV2SQLBasedIngestionTest

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@georgew5656 georgew5656 merged commit 50bae96 into apache:master Feb 1, 2024
83 checks passed
Copy link
Contributor

@suneet-s suneet-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had reviewed this change before it was merged, but hadn't pressed the approve button yet. So this is my post-merge LGTM.

Thanks @georgew5656 !

@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants