-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move INSERT & REPLACE validation to the Calcite validator #15908
Merged
Commits on Feb 14, 2024
-
ingestHandlers validate sqlNode as DruidSqlIngest instead of the sele…
…ct source node. Implemented validateInsert method in DruidSqlValidtor to validate the respective node and moved a lot of the validation being done previously in the ingestHandlers to this overriden method. In the next commit will try to pull back out some of this validation to make this code change smaller and easier to review.
Configuration menu - View commit details
-
Copy full SHA for 0dc3c5a - Browse repository at this point
Copy the full SHA 0dc3c5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6579bd8 - Browse repository at this point
Copy the full SHA 6579bd8View commit details -
Configuration menu - View commit details
-
Copy full SHA for e019b70 - Browse repository at this point
Copy the full SHA e019b70View commit details
Commits on Feb 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2565173 - Browse repository at this point
Copy the full SHA 2565173View commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d2f0e47 - Browse repository at this point
Copy the full SHA d2f0e47View commit details -
* resolve getEffectiveGranularity comment
* allow granularity mismatch * remove duplicate validation around unnamed columns
Configuration menu - View commit details
-
Copy full SHA for b475ecc - Browse repository at this point
Copy the full SHA b475eccView commit details -
Configuration menu - View commit details
-
Copy full SHA for cad940d - Browse repository at this point
Copy the full SHA cad940dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 50061d6 - Browse repository at this point
Copy the full SHA 50061d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12c3d60 - Browse repository at this point
Copy the full SHA 12c3d60View commit details
Commits on Feb 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3836330 - Browse repository at this point
Copy the full SHA 3836330View commit details -
Configuration menu - View commit details
-
Copy full SHA for eca4be2 - Browse repository at this point
Copy the full SHA eca4be2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 914553f - Browse repository at this point
Copy the full SHA 914553fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9328165 - Browse repository at this point
Copy the full SHA 9328165View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0608676 - Browse repository at this point
Copy the full SHA 0608676View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.