Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grouping on complex columns aka unifying GroupBy strategies #16068

Merged
merged 50 commits into from
Apr 24, 2024
+3,174 −2,483
Merged

Grouping on complex columns aka unifying GroupBy strategies #16068

Show file tree
Hide file tree
Changes from 42 commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
39d6a32
init
LakshSingla Mar 6, 2024
731d273
draft work
LakshSingla Mar 6, 2024
b01344a
more
LakshSingla Mar 7, 2024
6e16865
some stuff working
LakshSingla Mar 7, 2024
718eef9
group by complex col working
LakshSingla Mar 7, 2024
cbb1181
fixup
LakshSingla Mar 7, 2024
33de9a8
fixup
LakshSingla Mar 7, 2024
f1394f7
remove original strategies
LakshSingla Mar 12, 2024
bd82649
checkstyle
LakshSingla Mar 13, 2024
3017e4d
comments
LakshSingla Mar 14, 2024
f159f67
add benchmarks
LakshSingla Mar 14, 2024
638bf52
all dictionaries now use sorted map
LakshSingla Mar 14, 2024
b21faac
Merge branch 'master' into unified-group-by-strategies-2
LakshSingla Mar 14, 2024
ead1ddf
tests 1
LakshSingla Mar 19, 2024
25fc42c
tests and comments
LakshSingla Mar 20, 2024
58f8834
tests
LakshSingla Mar 21, 2024
5939715
fixup big mistake
LakshSingla Mar 22, 2024
0f620b0
Merge branch 'master' into unified-group-by-strategies-2
LakshSingla Mar 22, 2024
d8a250c
cleanup, refactor for diff strategies
LakshSingla Mar 27, 2024
2479155
group by on nested arrays, disallow topN and vector engine
LakshSingla Mar 28, 2024
e49206f
hash stuff
LakshSingla Mar 28, 2024
973fa88
some review, more tests
LakshSingla Apr 1, 2024
8b62073
fixup benchmark
LakshSingla Apr 2, 2024
53f1b54
Merge branch 'master' into unified-group-by-strategies-2
LakshSingla Apr 4, 2024
c07d77d
checkstyle
LakshSingla Apr 8, 2024
2e0fe26
codeql
LakshSingla Apr 8, 2024
a580326
static check
LakshSingla Apr 8, 2024
15fb3bb
static check
LakshSingla Apr 9, 2024
3066942
static check
LakshSingla Apr 9, 2024
8cd955e
delete
LakshSingla Apr 9, 2024
be500d5
tests fix
LakshSingla Apr 12, 2024
6090d82
openrewrite
LakshSingla Apr 12, 2024
f9bbc21
Revert "openrewrite"
LakshSingla Apr 12, 2024
c28eb79
openrewrite test
LakshSingla Apr 12, 2024
b51248f
Revert "openrewrite test"
LakshSingla Apr 12, 2024
031f586
Revert "Revert "openrewrite test""
LakshSingla Apr 12, 2024
170d8d9
openrewrite test
LakshSingla Apr 12, 2024
60c2b42
review comments
LakshSingla Apr 12, 2024
ad44b5f
test fix
LakshSingla Apr 15, 2024
f30c7c6
tests fix
LakshSingla Apr 16, 2024
6e2db86
tests fix
LakshSingla Apr 16, 2024
a3a0145
tests fix
LakshSingla Apr 17, 2024
e95731c
review 1, delete bogus class
LakshSingla Apr 18, 2024
dfb5c9f
review 1, more comments
LakshSingla Apr 19, 2024
a412386
Merge branch 'master' into unified-group-by-strategies-2
LakshSingla Apr 19, 2024
2098f90
cleanup todos, review comments
LakshSingla Apr 22, 2024
3fbadd9
sorting and limiting fixup
LakshSingla Apr 23, 2024
5d5c8ae
prevent round trip
LakshSingla Apr 24, 2024
ad2fb04
prevent round trip 2
LakshSingla Apr 24, 2024
7fe36b1
tests, and fixup flake, preserve old incorrect behaviour
LakshSingla Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/static-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,17 @@ jobs:
${MVN} install -q -ff -pl 'distribution' ${MAVEN_SKIP} ${MAVEN_SKIP_TESTS}

- name: rewrite:dryRun
id: rewrite-dryRun
run: |
${MVN} rewrite:dryRun ${MAVEN_SKIP}

- name: Upload open rewrite patch
LakshSingla marked this conversation as resolved.
Show resolved Hide resolved
if: ${{ failure() && steps.rewrite-dryRun.conclusion == 'failure' }}
uses: actions/upload-artifact@master
with:
name: Rewrite patch
path: ./target/rewrite/rewrite.patch

web-checks:
strategy:
fail-fast: false
Expand Down