Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heartbeat and zk-connected metrics in defaultMetrics.json #16209

Merged
merged 1 commit into from Apr 1, 2024

Conversation

tapojit047
Copy link
Contributor

@tapojit047 tapojit047 commented Mar 27, 2024

Fixes #16148

Description

I have updated https://github.com/apache/druid/blob/master/extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json this file and added the zk-connected and service/heartbeat metrics.

Release note

Improved: Prometheus-emitter extension now emits service/heartbeat and zk-connected metrics.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Signed-off-by: Tapajit Chandra Paul <tapajit@appscode.com>
@kfaraz kfaraz merged commit dbef348 into apache:master Apr 1, 2024
54 checks passed
@kfaraz
Copy link
Contributor

kfaraz commented Apr 1, 2024

Thanks for the changes, @tapojit047 !!

@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Druid prometheus-emitter does not emit all the metrics
3 participants