Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove junit-jupiter-api version to prevent inconsistent version #16210

Merged
merged 1 commit into from Mar 28, 2024

Conversation

fectrain
Copy link
Contributor

@fectrain fectrain commented Mar 27, 2024

Description

Fix #16211 .

Remove redundant junit-jupiter version from kubernetes-overlord-extensions as junit-bom version has been specified in root pom

<dependency>
    <groupId>org.junit</groupId>
    <artifactId>junit-bom</artifactId>
    <version>5.10.2</version>
    <type>pom</type>
    <scope>import</scope>
</dependency>

All test passed after fixing:
image


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@fectrain fectrain changed the title remove junit-jupiter-api version to prevent inconsistent version Remove junit-jupiter-api version to prevent inconsistent version Mar 27, 2024
Copy link
Contributor

@abhishekrb19 abhishekrb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for the fix 👍. All the other modules seem to just inherit the version from pom.xml.

@abhishekrb19 abhishekrb19 merged commit f995011 into apache:master Mar 28, 2024
55 checks passed
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants