MSQ: Fix issue where AUTO assignment would not respect maxWorkerCount. #16214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WorkerAssignmentStrategy.AUTO was missing a check for maxWorkerCount in the case where the inputs to a stage are not dynamically sliceable. A common case here is when the inputs to a stage are other stages.
github-actions
bot
added
Area - Batch Ingestion
Area - MSQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkerAssignmentStrategy.AUTOwas missing a check formaxWorkerCountin the case where the inputs to a stage are not dynamically sliceable. A common case here is when the inputs to a stage are other stages.This could manifest as an error message like
OffsetLimitFrameProcessorFactory must be configured with maxWorkerCount = 1when aLIMITis used along withWorkerAssignmentStrategy.AUTO.