Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore context flag for window functions #16229

Merged
merged 2 commits into from Apr 3, 2024

Conversation

somu-imply
Copy link
Contributor

@somu-imply somu-imply commented Apr 2, 2024

The flag still exists as window functions are still experimental. Once the issues on window functions are fixed, this flag can be reverted before GA.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions bot added Area - Batch Ingestion Area - Querying Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Apr 2, 2024
@soumyava soumyava marked this pull request as ready for review April 2, 2024 19:30
@cryptoe
Copy link
Contributor

cryptoe commented Apr 3, 2024

Changes LGTM. Though I would love a UT on the MSQ side which fails in case the flag is not set.

@cryptoe cryptoe merged commit 4bea865 into apache:master Apr 3, 2024
85 checks passed
@adarshsanjeev adarshsanjeev added this to the 30.0.0 milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants