handling window frame selection in case of same bound kind #16231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Range window
kgyrtkirk
reviewed
Apr 3, 2024
| @@ -187,7 +187,7 @@ public AggInterval next() | |||
| groupToRowIndex(relativeGroupId(1)) | |||
| ), | |||
| Interval.of( | |||
| groupToRowIndex(relativeGroupId(-lowerOffset)), | |||
| groupToRowIndex(relativeGroupId(lowerOffset < 0 ? lowerOffset : -lowerOffset)), | |||
There was a problem hiding this comment.
this doesn't look right - this is effectively: -Math.abs(lowerOffset)
this part was already working with relative offsets ; so I think it should be simply relativeGroupId(lowerOffset) - didn't that worked?
kgyrtkirk
reviewed
Apr 3, 2024
| int resultStorageIndex = 0; | ||
|
|
||
| // if the upper offset is -ve, then we need to ignore those many rows prior to the current row | ||
| int resultStorageIndex = -1 * Math.min(upperOffset, 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to handle the following cases in window frame selection
rows between unbounded preceding and x precedingrows between x following and unbounded followingrows between x preceding and y precedingrows between x following and y followingKey changed/added classes in this PR
DefaultFramedOnHeapAggregatable.javaDruidSqlValidator.javaWindowing.javaThis PR has: