web-console: ACE editor refactoring #16359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
vogievetsky
approved these changes
Apr 30, 2024
vogievetsky
pushed a commit
to vogievetsky/druid
that referenced
this pull request
May 13, 2024
* Move druid-sql completions to dsql mode * Use font-size 12 * Convert ace-modes to typescript * Move aceCompleters to class member * Use namespace imports
adarshsanjeev
pushed a commit
that referenced
this pull request
May 14, 2024
* Web console: surface more info on the supervisor view (#16318) * add rate and stats * better tabs * detail * add recent errors * update tests * don't let people hide the actions column because why * don't sort on actions * better way to agg * add timeouts * show error only once * fix tests and Explain showing up * only consider active tasks * refresh * fix tests * better formatting * web-console: ACE editor refactoring (#16359) * Move druid-sql completions to dsql mode * Use font-size 12 * Convert ace-modes to typescript * Move aceCompleters to class member * Use namespace imports * Web console: concat data when doing a durable storage download (#16375) * concat data * fix silly console.error --------- Co-authored-by: John Gozde <john@gozde.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves Druid SQL autocomplete information into the
dsqlmode itself and out of flexible-query-input to allow anyAceEditorinstance access to those completions via the mode.Some other Ace-related changes:
themeconfigurable via static memberThis PR has: