-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use canonical hostname instead of ip by default #16386
Use canonical hostname instead of ip by default #16386
Conversation
This changes the default behavior, need more people to review it. |
@@ -138,8 +138,8 @@ then | |||
setKey _common druid.zk.service.host "${ZOOKEEPER}" | |||
fi | |||
|
|||
DRUID_SET_HOST=${DRUID_SET_HOST:-1} | |||
if [ "${DRUID_SET_HOST}" = "1" ] | |||
DRUID_SET_HOST_IP=${DRUID_SET_HOST_IP:-0} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georgew5656 could you please review this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aho135 does this new default work okay with a raw docker run? i'm not exactly sure what
InetAddress.getLocalHost().getCanonicalHostName() returns there? i think it might be the container-id which might not work that well since its not reachable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@georgew5656 What did you have in mind as a raw docker run? The integration tests docker setup also uses InetAddress.getLocalHost().getCanonicalHostName() which just resolves to the name set in the docker-compose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the integration tests are passing then this seems fine to me
Thanks for the review and approval @georgew5656! Do you know who would be the right person to tag for review and merge? |
i'd say if @FrankChen021 also thinks this is good to go I can merge it |
Fixes #16352
Description
druid.indexer.task.restoreTasksOnRestart does not work by default for Docker based deployments on Kubernetes
Updates druid.sh to use canonical hostname for druid.host by default. Allows users to set environment variable DRUID_SET_HOST_IP=1 to use IP instead
Release note
Key changed/added classes in this PR
druid.sh
This PR has: