-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup logic from handoff API #16457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, @georgew5656 .
the cds-task-schema-publish-disabled test appears to be hanging and is not cancelling for some reason. i'm pretty sure this is unrelated so i'm going to merge |
I've seen this happen on various PRs after master has been merged into the PR branches. It didn't happen on #16250, the PR that was merged to master immediately before this one. That suggests that possibly this patch did something to make the |
Looking through the patch, though, I don't see anything that seems like it would have that effect… |
Nevermind, #16250 didn't run the ITs since it was a console only change. I don't think this patch is the one that did it. |
Some followup fixes from: #16310 (review)
Description
Making a few nit fixes from the PR in #16310 (review) for the handoff API
Key changed/added classes in this PR
Supervisor
SeekableStreamSupervisor
This PR has: