Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix task bootstrapping & simplify segment load/drop flows #16475

Merged
merged 48 commits into from
Jun 4, 2024
Merged

Fix task bootstrapping & simplify segment load/drop flows #16475

merged 48 commits into from
Jun 4, 2024

Commits on May 20, 2024

  1. Fix task bootstrap locations.

    @abhishekrb19
    abhishekrb19 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    388e100 View commit details
    Browse the repository at this point in the history

  2. Remove dependency of SegmentCacheManager from SegmentLoadDropHandler. 

    - The load drop handler code talks to the local cache manager via
SegmentManager.
    @abhishekrb19
    abhishekrb19 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    0cd0f5a View commit details
    Browse the repository at this point in the history

  3. Clean up unused imports and stuff.

    @abhishekrb19
    abhishekrb19 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    6ddcdd5 View commit details
    Browse the repository at this point in the history

  4. Test fixes.

    @abhishekrb19
    abhishekrb19 committed May 20, 2024
    Configuration menu
    Copy the full SHA
    e91b82c View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Intellij inspections and test bind.

    @abhishekrb19
    abhishekrb19 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6e563aa View commit details
    Browse the repository at this point in the history

  2. Clean up dependencies some more

    @abhishekrb19
    abhishekrb19 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    b242021 View commit details
    Browse the repository at this point in the history

  3. Extract test load spec and factory to its own class.

    @abhishekrb19
    abhishekrb19 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9666512 View commit details
    Browse the repository at this point in the history

  4. Cleanup test util

    @abhishekrb19
    abhishekrb19 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e2feca5 View commit details
    Browse the repository at this point in the history

  5. Pull SegmentForTesting out to TestSegmentUtils.

    @abhishekrb19
    abhishekrb19 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    fb018bb View commit details
    Browse the repository at this point in the history

  6. Fix up.

    @abhishekrb19
    abhishekrb19 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a51d92a View commit details
    Browse the repository at this point in the history

  7. Minor changes to infoDir

    @abhishekrb19
    abhishekrb19 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e2b6f18 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into fixup_task_bootstrap_inject

    @abhishekrb19
    abhishekrb19 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    633cc36 View commit details
    Browse the repository at this point in the history

  9. Replace server announcer mock and verify that.

    @abhishekrb19
    abhishekrb19 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    92a7bac View commit details
    Browse the repository at this point in the history

  10. Add tests.

    @abhishekrb19
    abhishekrb19 committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ee74c67 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. Merge branch 'master' into fixup_task_bootstrap_inject

    @abhishekrb19
    abhishekrb19 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    302834d View commit details
    Browse the repository at this point in the history

  2. Update javadocs.

    @abhishekrb19
    abhishekrb19 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8ad46b9 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Address review comments.

    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    800c1cb View commit details
    Browse the repository at this point in the history

  2. Separate methods for download and bootstrap load

    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    0604c44 View commit details
    Browse the repository at this point in the history

  3. Clean up return types and exception handling.

    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    83c2b59 View commit details
    Browse the repository at this point in the history

  4. No callback for loadSegment().

    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    7fe4b91 View commit details
    Browse the repository at this point in the history

  5. Minor cleanup

    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    351bd0c View commit details
    Browse the repository at this point in the history

  6. Pull out the test helpers into its own static class so it can have be… 

    …tter state control.
    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    206ca82 View commit details
    Browse the repository at this point in the history

  7. LocalCacheManager stuff

    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    a7de2fa View commit details
    Browse the repository at this point in the history

  8. Fix build.

    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    c5acbea View commit details
    Browse the repository at this point in the history

  9. Fix build.

    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    980ffb8 View commit details
    Browse the repository at this point in the history

  10. Address some CI warnings.

    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    9c38996 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'fixup_task_bootstrap_inject' of github.com:abhishekrb19… 

    …/incubator-druid into fixup_task_bootstrap_inject
    @abhishekrb19
    abhishekrb19 committed May 25, 2024
    Configuration menu
    Copy the full SHA
    3f9862d View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Minor updates to javadocs and test code.

    @abhishekrb19
    abhishekrb19 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    39b9c69 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fixup_task_bootstrap_inject

    @abhishekrb19
    abhishekrb19 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    0efbede View commit details
    Browse the repository at this point in the history

  3. Address some CodeQL test warnings and checkstyle fix.

    @abhishekrb19
    abhishekrb19 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1d18c4a View commit details
    Browse the repository at this point in the history

  4. Pass a Consumer<DataSegment> instead of boolean & rename variables.

    @abhishekrb19
    abhishekrb19 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    615bf09 View commit details
    Browse the repository at this point in the history

  5. Small updates

    @abhishekrb19
    abhishekrb19 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    1fd0c1e View commit details
    Browse the repository at this point in the history

  6. Remove one test constructor.

    @abhishekrb19
    abhishekrb19 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    29b7815 View commit details
    Browse the repository at this point in the history

  7. Remove the other constructor that wasn't initializing fully and updat… 

    …e usages.
    @abhishekrb19
    abhishekrb19 committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9bf4ace View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Cleanup withInfoDir() builder and unnecessary test hooks.

    @abhishekrb19
    abhishekrb19 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    c6b8cc8 View commit details
    Browse the repository at this point in the history

  2. Remove mocks and elaborate on comments.

    @abhishekrb19
    abhishekrb19 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    16658e1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fixup_task_bootstrap_inject

    @abhishekrb19
    abhishekrb19 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    ae49b07 View commit details
    Browse the repository at this point in the history

  4. Commentary

    @abhishekrb19
    abhishekrb19 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e162311 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fixup_task_bootstrap_inject

    @abhishekrb19
    abhishekrb19 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    b6f8f20 View commit details
    Browse the repository at this point in the history

  6. Fix a few Intellij inspection warnings.

    @abhishekrb19
    abhishekrb19 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    e02f5cb View commit details
    Browse the repository at this point in the history

  7. Suppress corePoolSize intellij-inspect warning. 

    The intellij-inspect tool doesn't seem to correctly inspect
lambda usages. See ScheduledExecutors.
    @abhishekrb19
    abhishekrb19 committed May 29, 2024
    Configuration menu
    Copy the full SHA
    98db446 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Update docs and add more tests.

    @abhishekrb19
    abhishekrb19 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8024d51 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fixup_task_bootstrap_inject

    @abhishekrb19
    abhishekrb19 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    da73aa6 View commit details
    Browse the repository at this point in the history

  3. Use hamcrest for asserting order on expectation.

    @abhishekrb19
    abhishekrb19 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f11da12 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Merge branch 'master' into fixup_task_bootstrap_inject

    @asdf2014
    asdf2014 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b036808 View commit details
    Browse the repository at this point in the history

  2. Shutdown bootstrap exec.

    @abhishekrb19
    abhishekrb19 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    c2c9fd1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fixup_task_bootstrap_inject' of github.com:abhishekrb19… 

    …/incubator-druid into fixup_task_bootstrap_inject
    @abhishekrb19
    abhishekrb19 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a16d69e View commit details
    Browse the repository at this point in the history

  4. Fix checkstyle

    @abhishekrb19
    abhishekrb19 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    f97d10f View commit details
    Browse the repository at this point in the history