Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a full copy of the parser and apply our modifications to it #16503

Closed
wants to merge 14 commits into from

Conversation

kgyrtkirk
Copy link
Member

To enable easier access to enhance the parser - instead of copying parts of it this PR proposes to keep a full copy with our modifications in the repo. This makes:

  • a more easier to understand build
  • the build will unpack the "base" version of the parser to sql/target/calcite-base-parser ; so its relatively easy to see what have changed
  • more freedom on what could be modified later
  • upgrade is "different":
    • this PR contains a script which could help during upgrades (dev/updgrade-calcite-parser)
    • it restores the parse into the original state and apply our modifications and the updated ones and then merge it - this process should more or less finish successfully

@kgyrtkirk
Copy link
Member Author

@rohangarg @gianm @clintropolis: I wonder if you could take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant