Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix redirect #16548

Merged
merged 3 commits into from
Jun 14, 2024
Merged

docs: fix redirect #16548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69569cb
doc: cleanup unnecessary redirect
317brian Jun 4, 2024
56813b0
restore redirect file entry. delete md file
317brian Jun 11, 2024
aa48573
Merge branch 'master' into del-redirect
317brian Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions docs/ingestion/flatten-json.md
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions website/redirects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,8 @@ const Redirects=[
},
{
"from": [
"/docs/latest/ingestion/flatten-json.html",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to keep this redirect, and remove the flatten-json md file instead? That way, all the redirects would be kept in one place.

Copy link
Contributor Author

@317brian 317brian Jun 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a tradeoff. We keep it all in one place, but redirects done this way always go to /latest since we didn't adopt Docusaurus's versioning feature. The one in the file will stay within the same version.

I don't have strong feelings about one over the other. Traditionally, I think we've just typically been fine with redirects always going to the latest version. So we can stick with tradition 🤣

"/docs/latest/ingestion/transform-spec.html"
"/docs/latest/ingestion/transform-spec.html",
"/docs/latest/ingestion/flatten-json.html"
],
"to": "/docs/latest/ingestion/ingestion-spec"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we split this into two entries? Since the Markdown file redirected to /docs/latest/ingestion/data-formats, we might want to keep that. But keep redirecting transform-spec to ingestion-spec.

Also, let's double-check the flatten-json redirection works as expected (maybe something is off, which would be why the markdown was added a couple of weeks ago?).

},
Expand Down
Loading