Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Azure extension #16585

Merged
merged 23 commits into from
Jun 20, 2024
Merged

Conversation

amaechler
Copy link
Contributor

Description

This PR revamps the documentation for the Azure extension. The existing extension docs are somewhat hard to follow because

  • it only describes part of the provided functionality
  • it is somewhat outdated (the properties supported for storage are not 100% accurate anymore)

One thing we could still add to this PR is a more detailed section about permissions / roles required for the various operations.


This PR has:

  • been self-reviewed.

Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving these docs! Left some suggestions.

docs/configuration/index.md Show resolved Hide resolved
docs/configuration/index.md Outdated Show resolved Hide resolved
docs/development/extensions-core/azure.md Outdated Show resolved Hide resolved
docs/development/extensions-core/azure.md Outdated Show resolved Hide resolved
docs/development/extensions-core/azure.md Outdated Show resolved Hide resolved
docs/development/extensions-core/azure.md Outdated Show resolved Hide resolved
docs/ingestion/input-sources.md Outdated Show resolved Hide resolved
docs/ingestion/input-sources.md Outdated Show resolved Hide resolved
docs/ingestion/input-sources.md Outdated Show resolved Hide resolved
docs/ingestion/input-sources.md Outdated Show resolved Hide resolved
amaechler and others added 17 commits June 11, 2024 15:52
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
@amaechler
Copy link
Contributor Author

Thanks for the detailed feedback @vtlim. I have addressed your comments now. Ready for another round! 🙇

@amaechler amaechler requested a review from vtlim June 18, 2024 20:35
Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for these improvements!

@vtlim vtlim merged commit ae70e18 into apache:master Jun 20, 2024
12 checks passed
@amaechler amaechler deleted the docs-azure-extension branch June 20, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants