-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web console: expose handoff API #16586
base: master
Are you sure you want to change the base?
Conversation
Where on the UI are the Task Group IDs found? If this is the "Group ID" value from the Tasks tab, then would it make more sense to implement the "Early Handoff" option on the Tasks tab instead of the Supervisor tab? I understand it is the Supervisor that needs the direct instruction and not the Task ... but from a user perspective it is the task that I am cycling, not the Supervisor. Thanks. John |
the task's taskGroupId is under the streaming task -> ioConfig -> taskGroupId. i think it still makes sense to have it on the supervisor (since you can specify multiple tasks to handoff, and like you said the api is operating on the supervisor). it would be nice to have a more explicit group -> task_id mapping available somewhere in the superivsor though. i have observed that the Statistics tab for the supervisor already shows tasks by ascending group id (1,2,3,4,5, etc) so maybe it could be there, or alternatively just in the status page |
web-console/src/dialogs/supervisor-handoff-dialog/supervisor-handoff-dialog.tsx
Outdated
Show resolved
Hide resolved
web-console/src/dialogs/supervisor-handoff-dialog/supervisor-handoff-dialog.tsx
Outdated
Show resolved
Hide resolved
web-console/src/dialogs/supervisor-handoff-dialog/supervisor-handoff-dialog.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions.
Verbiage ... do we need to make a distinction between "supervisor handoff" and "task group handoff"? I thought a "supervisor handoff" involved cycling all tasks for the supervisor ... this is what we can do by "Open in Data Loader" and then Submit without making any changes to the supervisor spec. If there is any ambiguity here it might be safer to always reference "task group(s)" as the thing being handed off. My understanding is that Supervisor is merely the orchestrator here. |
…andoff-dialog.tsx Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
…andoff-dialog.tsx Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
…andoff-dialog.tsx Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good.
Expose handoff API added in #16310