Update docs for K8s TaskRunner Dynamic Config #16600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdf2014
reviewed
Jun 14, 2024
|
@YongGang fyi |
YongGang
reviewed
Jun 14, 2024
...ain/java/org/apache/druid/k8s/overlord/execution/SelectorBasedPodTemplateSelectStrategy.java
Show resolved
Hide resolved
vtlim
reviewed
Jun 17, 2024
YongGang
reviewed
Jun 18, 2024
|
|
||
| return templates.getOrDefault(templateKey, templates.get("base")); | ||
| PodTemplate podTemplate = templates.getOrDefault(templateKey, templates.get("base")); |
There was a problem hiding this comment.
A non-null podTemplate will always be returned in this line of code as when loading templates it will make sure base template get configured here
vtlim
reviewed
Jun 18, 2024
| match any selector in the list, it will use the `base` pod template. | ||
|
|
||
| For a task to match a selector, all the conditions within the selector must match. A selector can match on | ||
| - `type`: Type of the task |
There was a problem hiding this comment.
Suggested change
| - `type`: Type of the task | |
| - `type`: Type of the task. |
vtlim
approved these changes
Jun 18, 2024
vtlim
reviewed
Jun 19, 2024
| |`SelectorBasedPodTemplateSelectStrategy`| This strategy evaluates a series of selectors, known as `selectors`, which are aligned with potential task properties. | false | | ||
| #### Pod template selection | ||
|
|
||
| The pod template adapapter can select which pod template should be used for a task using the [task runner execution config](#dynamic-config) |
There was a problem hiding this comment.
Suggested change
| The pod template adapapter can select which pod template should be used for a task using the [task runner execution config](#dynamic-config) | |
| The pod template adapter can select which pod template should be used for a task using the [task runner execution config](#dynamic-config) |
Raised by spell checker
|
Overruling CI because the k8s extension is not tested in these integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly a refactor of the docs added in #16510
While writing these docs, I realized that the use of a
defaultKeyin the dynamic config (that I suggested in the original patch) is not actually that helpful, so I removed it from the docs and the code.This PR has: