Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to override/specify python exec to use for build #16610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maytasm
Copy link
Contributor

@maytasm maytasm commented Jun 15, 2024

Allow user to override/specify python exec to use for build

Description

Building Druid requires Python to execute some python script like generate-binary-notice.py and generate-binary-license.py. These scripts may require packages to be installed (i.e. pyyaml). Some build environments may have python3 available but prevent job (running on that worker) to install packages to the machine python. These environments requires Python venv to be setup. This PR allows such Python venv to be specify and use in the build process.

i.e. An example build step

python -m venv .venv
.venv/bin/pip install pyyaml
mvn clean install package -Dpython.exec=.venv/bin/python -Pbundle-contrib-exts -Pdist....

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@findingrish
Copy link
Contributor

Thanks for the changes! Does it make sense to document the instructions here https://druid.apache.org/docs/latest/development/build/?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants