Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix druid.router.http.requestBuffersize not pass to Router management proxy #16611

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

maytasm
Copy link
Contributor

@maytasm maytasm commented Jun 15, 2024

Fix druid.router.http.requestBuffersize not pass to Router management proxy

Description

When router has management proxy enabled, we were not respecting the druid.router.http.requestBuffersize set in the Configuration. This PR fix the above issue by passing the value of druid.router.http.requestBuffersize from the config to the proxy servlet

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@maytasm maytasm merged commit 44268e7 into apache:master Jun 18, 2024
87 checks passed
@maytasm maytasm deleted the fix_requestBufferSize_for_proxy branch June 18, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants