Fix malformed period throwing ADMIN persona error
#16626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current exception is targeting the ADMIN persona. Catch that and turn it into a USER persona instead. Also, provide more context in the error message.
abhishekrb19
commented
Jun 18, 2024
processing/src/main/java/org/apache/druid/query/expression/ExprUtils.java
Outdated
Show resolved
Hide resolved
clintropolis
approved these changes
Jun 19, 2024
processing/src/main/java/org/apache/druid/query/expression/ExprUtils.java
Outdated
Show resolved
Hide resolved
…rUtils.java Co-authored-by: Clint Wylie <cjwylie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amaechler found out that when an invalid period is specified to the
TIME_FLOORfunction, theDruidExceptionthrown by the Calcite planner targets theADMINpersona rather thanUSER. This is easy to reproduce by running:"SELECT TIME_FLOOR(CURRENT_TIMESTAMP, 'PT1Y')"in the web-console.This PR fixes the persona by explicitly handling the
IllegalArgumentExceptionthrown during the Joda Time period instantiation, and make the exception user-facing. Also, the error message is now decorated with more context.This PR has: