Increase query cancellation timeout in the router #16656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptoe
reviewed
Jun 27, 2024
| @@ -104,7 +104,7 @@ public class AsyncQueryForwardingServlet extends AsyncProxyServlet implements Qu | |||
| private static final String PROPERTY_SQL_ENABLE = "druid.router.sql.enable"; | |||
| private static final String PROPERTY_SQL_ENABLE_DEFAULT = "false"; | |||
|
|
|||
| private static final int CANCELLATION_TIMEOUT_MILLIS = 500; | |||
| private static final int CANCELLATION_TIMEOUT_MILLIS = 1000; | |||
There was a problem hiding this comment.
Should we bump it up to 5 seconds ?
The reason is for a cluster that is fully loaded, a cancel call would help ease the pressure on the broker.
cc @abhishekagarwal87?
There was a problem hiding this comment.
How did you arrive at the 5 second number?
There was a problem hiding this comment.
Updated to 5 seconds.
asdf2014
requested changes
Jul 8, 2024
| @@ -104,7 +104,7 @@ public class AsyncQueryForwardingServlet extends AsyncProxyServlet implements Qu | |||
| private static final String PROPERTY_SQL_ENABLE = "druid.router.sql.enable"; | |||
| private static final String PROPERTY_SQL_ENABLE_DEFAULT = "false"; | |||
|
|
|||
| private static final int CANCELLATION_TIMEOUT_MILLIS = 500; | |||
| private static final int CANCELLATION_TIMEOUT_MILLIS = 1000; | |||
There was a problem hiding this comment.
Nit: let's avoid magic number 😄
Suggested change
| private static final int CANCELLATION_TIMEOUT_MILLIS = 1000; | |
| private static final int CANCELLATION_TIMEOUT_MILLIS = TimeUnit.SECONDS.toMillis(1);; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the timeout duration is hardcoded to 500 ms, this leads to frequent query cancellation failures when the Brokers are under load.
Increasing this value to 1 second.