Fix failure in nested groupBy with multiple aggregators with same… #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ldName Seems to be a side effect of using an intermediate IncrementalIndex to handle nested group bys. Fix is to prevent adding multiple columns with the same fieldName to the index. The AggregatorFactory type may be lost since it doesn't add subsequent factories with the same name, but I don't think that affects the function of the intermediate index. This is a hack in the sense that the real solution is to re-write group-bys to not require massaging the data to work with IncrementalIndex. Closes #1419
| .setGranularity(QueryRunnerTestHelper.dayGran) | ||
| .build(); | ||
|
|
||
| GroupByQueryRunnerTestHelper.runQuery(factory, runner, query); |
There was a problem hiding this comment.
There should be a TestHelper.assertExpectedObjects here for what the result of the query is supposed to be.
There was a problem hiding this comment.
The result is covered by other similar tests so I didn't want to make a redundant test. This case used to throw an exception before the change so the test is to assert that no exception is thrown more so than the results. If you think there's value in verifying the results I can do that.
There was a problem hiding this comment.
I think that if there's value in testing a query at all, then there is definitely value in making sure that the results are what you would expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fieldName
Seems to be a side effect of using an intermediate IncrementalIndex to handle nested group bys. Fix is to prevent adding multiple columns with the same fieldName to the index. The AggregatorFactory type may be lost since it doesn't add subsequent factories with the same name, but I don't think that affects the function of the intermediate index.
This is a hack in the sense that the real solution is to re-write groupbys to not require massaging the data to work with IncrementalIndex.
Closes #1419