DataSchema: Exclude metric names from dimension list. #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
build failure does look like a genuine failure in this case 👍 (after test fix and travis success) |
Otherwise we could end up with a metric and a dimension with the same column name.
gianm
force-pushed
the
data-schema-exclude-metric-names
branch
from
5aefddf
to
6b908a5
Compare
|
@fjy @himanshug fixed the test |
fjy
added a commit
that referenced
this pull request
Nov 7, 2015
DataSchema: Exclude metric names from dimension list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we could end up with a metric and a dimension with the same column name.