-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc update to make it easy to find how to do re-indexing or delta ingestion #2100
Conversation
@@ -16,7 +16,7 @@ h2. Data Ingestion | |||
* "Schema Design":../ingestion/schema-design.html | |||
* "Schema Changes":../ingestion/schema-changes.html | |||
* "Realtime Ingestion":../ingestion/realtime-ingestion.html | |||
* "Batch Ingestion":../ingestion/batch-ingestion.html | |||
* "Batch ingestion or Re-indexing or Delta ingestion":../ingestion/batch-ingestion.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Re-indexing should be a completely different section in the ingestion docs with these explicit steps listed out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean adding another file batch-delta-ingestion.md and link it in "Ingestion" section in the TOC file ? But that new file will only say what is updated in "docs/content/ingestion/batch-ingestion.md
" in this PR. is that enough or you are looking for something more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should add batch-delta-ingestion.md and link it from the TOC. The document can be short but we can move the contents around reingestion out of batch-ingestion or repeat the relevant parts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, will update soon.
96204eb
to
1776c34
Compare
@fjy changed as per review comments. |
@@ -17,6 +17,7 @@ h2. Data Ingestion | |||
* "Schema Changes":../ingestion/schema-changes.html | |||
* "Realtime Ingestion":../ingestion/realtime-ingestion.html | |||
* "Batch Ingestion":../ingestion/batch-ingestion.html | |||
* "Batch Re-Indexing and Delta-Ingestion":../ingestion/batch-delta-ingestion.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you feel about calling this 'Updating Existing Data'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
1776c34
to
4197d01
Compare
4197d01
to
48de9df
Compare
@fjy made various changes to address all review comments, pls take another look. I have placed links for users to learn details about ingestion spec etc, this doc focuses on data updation only. |
👍 |
doc update to make it easy to find how to do re-indexing or delta ingestion
received this feedback from users that it was hard to find so making very explicit.