Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ChatHandlerServerModule to realtime example #2189

Merged
merged 1 commit into from
Jan 4, 2016
Merged

add ChatHandlerServerModule to realtime example #2189

merged 1 commit into from
Jan 4, 2016

Conversation

pjain1
Copy link
Member

@pjain1 pjain1 commented Jan 4, 2016

Realtime Example also need the bindings in this module otherwise it fails to run

@fjy
Copy link
Contributor

fjy commented Jan 4, 2016

👍

1 similar comment
@jaehc
Copy link
Contributor

jaehc commented Jan 4, 2016

👍

@nishantmonu51
Copy link
Member

👍, is there any Unit test that we can add to make sure examples don't get broken in future with other changes ?

fjy added a commit that referenced this pull request Jan 4, 2016
add ChatHandlerServerModule to realtime example
@fjy fjy merged commit 43e7523 into apache:master Jan 4, 2016
@pjain1
Copy link
Member Author

pjain1 commented Jan 4, 2016

@nishantmonu51 I cannot think of a way off the top of my head, I will think about it.

@pjain1 pjain1 deleted the fix_realtime_example branch January 4, 2016 16:22
fjy added a commit that referenced this pull request Jan 26, 2016
[BACKPORT #2189] add ChatHandlerServerModule to realtime example
@gianm gianm mentioned this pull request Jan 26, 2016
@fjy fjy modified the milestone: 0.9.0 Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants