Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bytebuffer-collections to 0.2.4 #2227

Merged
merged 1 commit into from
Jan 7, 2016
Merged

Update bytebuffer-collections to 0.2.4 #2227

merged 1 commit into from
Jan 7, 2016

Conversation

drcrallen
Copy link
Contributor

Fixes #2218
Pulls in fix for RoaringBitmap/RoaringBitmap#61

@drcrallen drcrallen added the Bug label Jan 7, 2016
@nishantmonu51
Copy link
Member

👍

@gianm
Copy link
Contributor

gianm commented Jan 7, 2016

👍 after travis

@drcrallen
Copy link
Contributor Author

Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 71.126 sec <<< FAILURE! - in io.druid.server.namespace.cache.JDBCExtractionNamespaceTest
testFindNew[null](io.druid.server.namespace.cache.JDBCExtractionNamespaceTest)  Time elapsed: 60.92 sec  <<< ERROR!
java.lang.RuntimeException: java.util.concurrent.TimeoutException
    at java.util.concurrent.FutureTask.get(FutureTask.java:205)
    at io.druid.server.namespace.cache.JDBCExtractionNamespaceTest.tearDown(JDBCExtractionNamespaceTest.java:307)

@drcrallen drcrallen closed this Jan 7, 2016
@drcrallen drcrallen reopened this Jan 7, 2016
@drcrallen
Copy link
Contributor Author

The big question is: Do we want this added to an 0.8.3-rc4 ?

@fjy
Copy link
Contributor

fjy commented Jan 7, 2016

@drcrallen I think it is fine for this to wait.

xvrl added a commit that referenced this pull request Jan 7, 2016
Update bytebuffer-collections to 0.2.4
@xvrl xvrl merged commit 24010b0 into master Jan 7, 2016
@xvrl xvrl deleted the bytebufferUpdate branch January 7, 2016 21:35
@xvrl
Copy link
Member

xvrl commented Jan 7, 2016

@fjy in that case we should mark roaring as unsafe to use in 0.8.x?

@gianm
Copy link
Contributor

gianm commented Jan 7, 2016

I think 0.8.3-rc4 is appropriate, as roaring is not an experimental feature so bug fixes are important.

@gianm
Copy link
Contributor

gianm commented Jan 7, 2016

0.8.4 would be cool too.

drcrallen added a commit that referenced this pull request Jan 7, 2016
@gianm gianm mentioned this pull request Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Still, complement of roaring bitmap does not work correctly
5 participants