WIP: optionally configure DirectDruidClient to use /druid/v3 instead of /druid/v2 #3323
Conversation
himanshug
force-pushed
the
context_from_historicals
branch
from
c112eeb
to
44e920d
Compare
himanshug
changed the title
himanshug
changed the title
|
Proposing as part of 0.9.3 for now as not to block 0.9.2 |
| @Override | ||
| public JsonParserIterator<T> make() | ||
| Sequence<T> retVal; | ||
| if (useV3QueryUrl) { |
There was a problem hiding this comment.
I propose using a factory here with the two default implementations being a queryv2 and a queryv3 factory which can generate the proper return value.
…in response json instead of HTTP header
himanshug
force-pushed
the
context_from_historicals
branch
from
eb07905
to
f6a7142
Compare
|
@himanshug is this still WIP? |
|
@fjy it was ready but depends on #3319 so removing from 0.9.3 till that is merged. also i'm planning to make additional changes to #3319 which will require changes here too. see #3319 (comment) |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
for talking to historicals and accumulate the response context.
DEPENDS ON #3319 and is reviewable after same is merged , creating PR for lookahead
enabled with "druid.broker.httpClient.useV3QueryUrl=true" in runtime.properties.
response context from broker would include response context from various historicals as...
{
"result": [.... ]
"context": {
.....
"historical1" : {...},
"historical2" : {....}
}