fix useExplicitVersion #3559
Merged
fix useExplicitVersion #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashdw
reviewed
Oct 10, 2016
| ); | ||
| return TaskStatus.failure(getId()); | ||
| if (indexerSchema.getTuningConfig().isUseExplicitVersion()) { | ||
| if (specVersion.compareTo(version) < 0) { |
There was a problem hiding this comment.
null/empty check for specVersion? where isUseExplicitVersion is set to true but specVersion is missing in HadoopIngestionSpec.
There was a problem hiding this comment.
My bad, HadoopTunningConfig is taking care of above,
this.version = version == null ? new DateTime().toString() : version;
There was a problem hiding this comment.
I think specVersion cannot be null, see this - https://github.com/druid-io/druid/blob/master/indexing-hadoop/src/main/java/io/druid/indexer/HadoopTuningConfig.java#L115
|
👍 |
|
👍 after travis. |
|
👍 |
fundead
pushed a commit
to fundead/druid
that referenced
this pull request
Dec 7, 2016
dgolitsyn
pushed a commit
to metamx/druid
that referenced
this pull request
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regression in #3554