Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto license checking #3836

Merged
merged 2 commits into from Jan 11, 2017
Merged

Enable auto license checking #3836

merged 2 commits into from Jan 11, 2017

Conversation

jihoonson
Copy link
Contributor

@jihoonson jihoonson commented Jan 10, 2017

This patch contains a bunch of changes for license headers of java files. Key changes are:

  • Added LICENSE.txt to codestyle directory.
  • Added <headerLocation>codestyle/LICENSE.txt</headerLocation> to {project.root}/pom.xml
  • Added the following contents to checkstyle.xml
<module name="Header">
    <property name="headerFile" value="${checkstyle.header.file}"/>
    <property name="fileExtensions" value="java"/>
  </module>
  • Added <suppress checks="Header" files="[\\/]target[\\/]generated-test-sources[\\/]" /> to checkstyle-suppressions.xml

This change is Reviewable

@gianm
Copy link
Contributor

gianm commented Jan 10, 2017

Thanks @jihoonson, more checkstyles are more better!

I reviewed the changes ignoring whitespace (https://github.com/druid-io/druid/pull/3836/files?w=1) and it looks like other than whitespace, mostly you are adding headers to files that miss them, and changing the old style headers in druid-api to new style headers. That's good, since we just moved them in a while back without updating the headers.

Could you please fix the headers on SQLServerConnector.java, BoundDimFilterTest.java, SQLMetadataRuleManager.java, and SQLMetadataSegmentPublisher.java? They all have two headers now.

After that the change LGTM

@gianm gianm added this to the 0.10.0 milestone Jan 10, 2017
@fjy
Copy link
Contributor

fjy commented Jan 10, 2017

👍 from me after addressing @gianm's comment

@jihoonson
Copy link
Contributor Author

@gianm, @fjy thank you for your review. I fixed it.

Copy link
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@fjy fjy merged commit d80bec8 into apache:master Jan 11, 2017
dgolitsyn pushed a commit to metamx/druid that referenced this pull request Feb 14, 2017
* Enable license checking

* Clean duplicated license headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants