Don't allow '__time' as a GroupBy output field name #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-wei
changed the title
gianm
reviewed
Feb 23, 2017
| @@ -572,6 +573,10 @@ private static void verifyOutputNames( | |||
| throw new IAE("Duplicate output name[%s]", postAggregator.getName()); | |||
| } | |||
| } | |||
|
|
|||
| if (outputNames.contains(Column.TIME_COLUMN_NAME)) { | |||
| throw new IAE("'__time' cannot be used as an output name for dimensions, aggregators, or post-aggregators."); | |||
There was a problem hiding this comment.
Might as well do %s and Column.TIME_COLUMN_NAME here since you went to the trouble of doing it in the if check.
|
👍 after nit fix for log msg |
|
👍 |
|
@jon-wei, please update the log msg and then feel free to merge it yourself since there's enough +1s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallows
__timeas an output field for GroupBy queriesFixes #3687