Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "granularity" from IngestSegmentFirehose. #4110

Merged
merged 1 commit into from
Mar 24, 2017
Merged

Remove "granularity" from IngestSegmentFirehose. #4110

merged 1 commit into from
Mar 24, 2017

Commits on Mar 24, 2017

  1. Remove "granularity" from IngestSegmentFirehose. 

    It wasn't doing anything useful (the sequences were being concatted, and
cursor.getTime() wasn't being called) and it defaulted to Granularities.NONE.
Changing it to Granularities.ALL gave me a 700x+ performance boost on a
small dataset I was reindexing (2m27s to 365ms). Most of that was from avoiding
making a lot of unnecessary column selectors.
    @gianm
    gianm committed Mar 24, 2017
    Configuration menu
    Copy the full SHA
    0e47c9e View commit details
    Browse the repository at this point in the history