Coordinator segment balancer max load queue fix #5888
Conversation
|
This fix as it is currently, will remove servers with a 'full' load queue from consideration as both a destination to move segments to, as well as a source to move segments from. If it is more preferable to still allow moving segments off of these servers, the server list could be duplicated and pick segments from the full set, but on consider moving to the filtered set. |
|
Cool, I think it'd be good to still allow moves from servers that have a full load queue |
| @@ -103,6 +103,7 @@ private void balanceTier( | |||
| return; | |||
| } | |||
|
|
|||
| final List<ServerHolder> entireServerHolderList = Lists.newArrayList(servers); | |||
There was a problem hiding this comment.
maybe rename these to "sourceServerHolderList" and "destinationServerHolderList"
There was a problem hiding this comment.
didn't use those exactly, but gave those and some other variables some better names
|
Updated to let segments still be moved from servers with a full load queue |
* Coordinator segment balancer will now respect "maxSegmentsInNodeLoadingQueue" config * allow moves from full load queues * better variable names
* Coordinator segment balancer will now respect "maxSegmentsInNodeLoadingQueue" config * allow moves from full load queues * better variable names
…#5970) * Coordinator segment balancer will now respect "maxSegmentsInNodeLoadingQueue" config * allow moves from full load queues * better variable names
DruidCoordinatorBalancerwill now respect config settingmaxSegmentsInNodeLoadingQueue, filtering servers which cross the threshold from potential move targets.Related to #5882