-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL] Fix missing postAggregations for Timeseries and TopN #5912
Merged
gianm
merged 3 commits into
apache:master
from
jihoonson:fix-post-agg-for-timeseries-topn
Jun 29, 2018
Merged
[SQL] Fix missing postAggregations for Timeseries and TopN #5912
gianm
merged 3 commits into
apache:master
from
jihoonson:fix-post-agg-for-timeseries-topn
Jun 29, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
approved these changes
Jun 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
gianm
approved these changes
Jun 28, 2018
@jihoonson the failure looks legit… probably related to "second" query granularity being too much for the test box to handle?
|
@gianm thanks. I've fixed the test. |
thanks @jihoonson! |
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Jul 2, 2018
* [SQL] Fix missing postAggregations for Timeseries and TopN * fix build * fix test
I believe this fixes a bug introduced by #5788, so it must be included in 0.12.3. I'll mark it. |
This was referenced Aug 25, 2018
gianm
pushed a commit
to gianm/druid
that referenced
this pull request
Aug 26, 2018
* [SQL] Fix missing postAggregations for Timeseries and TopN * fix build * fix test
fjy
pushed a commit
that referenced
this pull request
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SQL, postAggregations such as
SUM(m1) + SUM(m2)
are missing in the query plan, thereby resulting in nulls. See the newly added unit tests in the patch for example queries.This change is