Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in SegmentAnalyzer.analyzeComplexColumn() #5939 #5954

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Fix bug in SegmentAnalyzer.analyzeComplexColumn() #5939 #5954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion processing/src/main/java/io/druid/query/metadata/SegmentAnalyzer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ private ColumnAnalysis analyzeComplexColumn(
return new ColumnAnalysis(typeName, hasMultipleValues, 0, null, null, null, null);
}

final int length = column.getLength();
final int length = complexColumn.getLength();
for (int i = 0; i < length; ++i) {
size += inputSizeFn.apply(complexColumn.getRowValue(i));
}
Expand Down
1 change: 1 addition & 0 deletions processing/src/main/java/io/druid/segment/column/ComplexColumn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public interface ComplexColumn extends BaseColumn
Class<?> getClazz();
String getTypeName();
Object getRowValue(int rowNum);
int getLength();

@Override
void close();
Expand Down
6 changes: 6 additions & 0 deletions processing/src/main/java/io/druid/segment/column/IndexedComplexColumn.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ public Object getRowValue(int rowNum)
return column.get(rowNum);
}

@Override
public int getLength()
{
return column.size();
}

@Override
public void close()
{
Expand Down