Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing doc link for operations/http-compression.html #7110

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Feb 20, 2019

The PR contains:

  1. Add missing doc link for operations/http-compression.html;
  2. Fix magic numbers in test cases using JettyServerInitUtils.wrapWithDefaultGzipHandler

Will fix #7109 and a suggestion[1] in #5624 .

[1] #5624 (comment)

@zhztheplayer
Copy link
Member Author

I will resolve Travis CI warnings later.

Copy link
Contributor

@gianm gianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please adjust based on the Travis warnings.

@zhztheplayer
Copy link
Member Author

Thanks @gianm! Travis CI warnings are fixed.

@fjy fjy added this to the 0.15.0 milestone Mar 11, 2019
@@ -3274,12 +3274,14 @@
"balanced-match": {
"version": "1.0.0",
"bundled": true,
"dev": true
"dev": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the changes to this file, they seem unrelated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, seems to be my mistake, thank you for the catch.

…numbers in test cases using JettyServerInitUtils.wrapWithDefaultGzipHandler
@clintropolis clintropolis merged commit f9d99b2 into apache:master Mar 13, 2019
clintropolis pushed a commit that referenced this pull request Apr 24, 2019
…numbers in test cases using JettyServerInitUtils.wrapWithDefaultGzipHandler (#7110)
@clintropolis clintropolis modified the milestones: 0.15.0, 0.14.1 Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing doc link for operations/http-compression.html
4 participants