-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing doc link for operations/http-compression.html #7110
Conversation
I will resolve Travis CI warnings later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please adjust based on the Travis warnings.
Thanks @gianm! Travis CI warnings are fixed. |
web-console/package-lock.json
Outdated
@@ -3274,12 +3274,14 @@ | |||
"balanced-match": { | |||
"version": "1.0.0", | |||
"bundled": true, | |||
"dev": true | |||
"dev": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's with the changes to this file, they seem unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, seems to be my mistake, thank you for the catch.
…numbers in test cases using JettyServerInitUtils.wrapWithDefaultGzipHandler
…numbers in test cases using JettyServerInitUtils.wrapWithDefaultGzipHandler (#7110)
The PR contains:
Will fix #7109 and a suggestion[1] in #5624 .
[1] #5624 (comment)