Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conflicting information in configuration doc #7299

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Fix conflicting information in configuration doc #7299

merged 2 commits into from
Mar 19, 2019

Conversation

justinborromeo
Copy link
Contributor

The doc says that both "noop" and "logging" emitters are the default in different places. Based on the code in EmitterModule, "noop" is the actual default:

      if (emitter == null) {
        emitter = findEmitter(NoopEmitterModule.EMITTER_TYPE, emitterBindings);
      }

@gianm gianm merged commit ff94bd1 into apache:master Mar 19, 2019
@justinborromeo justinborromeo deleted the fix-config-doc branch March 19, 2019 21:57
clintropolis pushed a commit that referenced this pull request Apr 24, 2019
@justinborromeo @clintropolis
Fix conflicting information in configuration doc (#7299)
cdc7b63 
* Doc fix

* Fix typo
@clintropolis clintropolis added this to the 0.14.1 milestone Apr 24, 2019
@clintropolis clintropolis mentioned this pull request Apr 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianm gianm gianm approved these changes

@jon-wei jon-wei jon-wei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinborromeo @gianm @jon-wei @clintropolis