Fix two issues with Coordinator -> Overlord communication. #7412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) ClientCompactQuery needs to recognize the potential for 'intervals' to be set instead of 'segments'. The lack of this led to a NullPointerException on DruidCoordinatorSegmentCompactor.java:102. 2) In two locations (DruidCoordinatorSegmentCompactor, DruidCoordinatorCleanupPendingSegments) tasks were being retrieved using waiting/pending/running tasks in the wrong order: by checking 'running' first and then 'pending', tasks could be missed if they moved from 'pending' to 'running' in between the two calls. Replaced these methods with calls to 'getActiveTasks', a new method that does the calls in the right order.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Apr 8, 2019
* Fix two issues with Coordinator -> Overlord communication. 1) ClientCompactQuery needs to recognize the potential for 'intervals' to be set instead of 'segments'. The lack of this led to a NullPointerException on DruidCoordinatorSegmentCompactor.java:102. 2) In two locations (DruidCoordinatorSegmentCompactor, DruidCoordinatorCleanupPendingSegments) tasks were being retrieved using waiting/pending/running tasks in the wrong order: by checking 'running' first and then 'pending', tasks could be missed if they moved from 'pending' to 'running' in between the two calls. Replaced these methods with calls to 'getActiveTasks', a new method that does the calls in the right order. * Remove unused import.
gianm
added a commit
to implydata/druid-public
that referenced
this pull request
Apr 14, 2019
* Fix two issues with Coordinator -> Overlord communication. 1) ClientCompactQuery needs to recognize the potential for 'intervals' to be set instead of 'segments'. The lack of this led to a NullPointerException on DruidCoordinatorSegmentCompactor.java:102. 2) In two locations (DruidCoordinatorSegmentCompactor, DruidCoordinatorCleanupPendingSegments) tasks were being retrieved using waiting/pending/running tasks in the wrong order: by checking 'running' first and then 'pending', tasks could be missed if they moved from 'pending' to 'running' in between the two calls. Replaced these methods with calls to 'getActiveTasks', a new method that does the calls in the right order. * Remove unused import.
clintropolis
pushed a commit
that referenced
this pull request
Apr 24, 2019
* Fix two issues with Coordinator -> Overlord communication. 1) ClientCompactQuery needs to recognize the potential for 'intervals' to be set instead of 'segments'. The lack of this led to a NullPointerException on DruidCoordinatorSegmentCompactor.java:102. 2) In two locations (DruidCoordinatorSegmentCompactor, DruidCoordinatorCleanupPendingSegments) tasks were being retrieved using waiting/pending/running tasks in the wrong order: by checking 'running' first and then 'pending', tasks could be missed if they moved from 'pending' to 'running' in between the two calls. Replaced these methods with calls to 'getActiveTasks', a new method that does the calls in the right order. * Remove unused import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientCompactQuery needs to recognize the potential for 'intervals'
to be set instead of 'segments'. The lack of this led to a
NullPointerException on DruidCoordinatorSegmentCompactor.java:102.
In two locations (DruidCoordinatorSegmentCompactor,
DruidCoordinatorCleanupPendingSegments) tasks were being retrieved
using waiting/pending/running tasks in the wrong order: by checking
'running' first and then 'pending', tasks could be missed if they
moved from 'pending' to 'running' in between the two calls. Replaced
these methods with calls to 'getActiveTasks', a new method that does
the calls in the right order.