Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time taken by last query in SQL view #7421

Merged
merged 4 commits into from
Apr 11, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions web-console/src/components/sql-control.scss
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,16 @@
}

.buttons {
position: relative;

button{
margin-right: 15px;
}

.query-elapsed {
position: absolute;
right: 10px;
}
}

}
Expand Down
9 changes: 7 additions & 2 deletions web-console/src/components/sql-control.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export interface SqlControlProps extends React.Props<any> {
initSql: string | null;
onRun: (query: string) => void;
onExplain: (query: string) => void;
queryElapsed: number | null;
}

export interface SqlControlState {
Expand Down Expand Up @@ -166,7 +167,7 @@ export class SqlControl extends React.Component<SqlControlProps, SqlControlState
}

render() {
const { onRun, onExplain } = this.props;
const { onRun, onExplain, queryElapsed } = this.props;
const { query, autoCompleteOn } = this.state;

const isRune = query.trim().startsWith('{');
Expand Down Expand Up @@ -217,7 +218,11 @@ export class SqlControl extends React.Component<SqlControlProps, SqlControlState
<Button rightIcon={IconNames.CARET_RIGHT} onClick={() => onRun(query)}>
{isRune ? 'Rune' : 'Run'}
</Button>
{!isRune ? SqlControlPopover : null}
{!isRune && SqlControlPopover}
{
queryElapsed &&
<span className={'query-elapsed'}> Last query took {(queryElapsed / 1000).toFixed(2)} seconds</span>
}
shuqi7 marked this conversation as resolved.
Show resolved Hide resolved
</div>
</div>;
}
Expand Down
35 changes: 26 additions & 9 deletions web-console/src/views/sql-view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ import {
localStorageGet, LocalStorageKeys,
localStorageSet, parseQueryPlan,
queryDruidRune,
queryDruidSql, QueryManager, SemiJoinQueryExplanation
queryDruidSql, QueryManager,
SemiJoinQueryExplanation
} from '../utils';

import "./sql-view.scss";
Expand All @@ -46,11 +47,17 @@ export interface SqlViewState {
explainResult: BasicQueryExplanation | SemiJoinQueryExplanation | string | null;
loadingExplain: boolean;
explainError: Error | null;
queryElapsed: number | null;
}

interface SqlQueryResult {
queryResult: HeaderRows;
queryElapsed: number;
}

export class SqlView extends React.Component<SqlViewProps, SqlViewState> {

private sqlQueryManager: QueryManager<string, HeaderRows>;
private sqlQueryManager: QueryManager<string, SqlQueryResult>;
private explainQueryManager: QueryManager<string, any>;

constructor(props: SqlViewProps, context: any) {
Expand All @@ -62,34 +69,42 @@ export class SqlView extends React.Component<SqlViewProps, SqlViewState> {
explainDialogOpen: false,
loadingExplain: false,
explainResult: null,
explainError: null
explainError: null,
queryElapsed: null
};
}

componentDidMount(): void {
this.sqlQueryManager = new QueryManager({
processQuery: async (query: string) => {
const startTime = new Date();
if (query.trim().startsWith('{')) {
// Secret way to issue a native JSON "rune" query
const runeQuery = Hjson.parse(query);
return decodeRune(runeQuery, await queryDruidRune(runeQuery));

const result = await queryDruidRune(runeQuery);
return {
queryResult: decodeRune(runeQuery, result),
queryElapsed: new Date().valueOf() - startTime.valueOf()
};
} else {
const result = await queryDruidSql({
query,
resultFormat: "array",
header: true
});

return {
header: (result && result.length) ? result[0] : [],
rows: (result && result.length) ? result.slice(1) : []
queryResult: {
header: (result && result.length) ? result[0] : [],
rows: (result && result.length) ? result.slice(1) : []
},
queryElapsed: new Date().valueOf() - startTime.valueOf()
};
}
},
onStateChange: ({ result, loading, error }) => {
this.setState({
result,
result: result ? result.queryResult : null,
queryElapsed: result ? result.queryElapsed : null,
loading,
error
});
Expand Down Expand Up @@ -158,6 +173,7 @@ export class SqlView extends React.Component<SqlViewProps, SqlViewState> {

render() {
const { initSql } = this.props;
const { queryElapsed } = this.state;

return <div className="sql-view app-view">
<SqlControl
Expand All @@ -167,6 +183,7 @@ export class SqlView extends React.Component<SqlViewProps, SqlViewState> {
this.sqlQueryManager.runQuery(q);
}}
onExplain={(q: string) => this.getExplain(q)}
queryElapsed={queryElapsed}
/>
{this.renderResultTable()}
{this.renderExplainDialog()}
Expand Down