-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No SQL mode in web console #7493
Conversation
shuqi7
commented
Apr 16, 2019
•
edited
Loading
edited
- Added 'No SQL mode' in the web console where all data retrieved from the server is through sending GET requests to Druid APIs instead of running SQL queries, just like the legacy consoles
- No SQL mode is enabled when the broker for SQL query is down
- Client-side workaround to fix 0.14 incubating New router unified-console UI shows 0 historical nodes when a cluster has been installed and historicals has no data yet #7498 until Druid SQL returns servers which have no data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell that I am not a fan of reduce?
Made a quick note on the wording of the notice and I think it is good otherwise. 👍 once my comment above is addressed. |
let servers: ServerQueryResultRow[]; | ||
if (!noSqlMode) { | ||
servers = await queryDruidSql({ query }); | ||
if (servers.length === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will implement another way of querying the servers in a separate PR
* Added no sql mode * Use status code * Add no sql mode to server view * add sql broker check to decide if no sql mode should be enabled * Fix historicals in home view * Name change * Add types for query result; improved functions * Fixed a conflict/bug * Fixed a bug * multiple fix * removed unused imports * terminate query manager * fix wording